[bisq-network/bisq] Refactor getFundingAddresses to use memoization (#4322)

[Stan]

This PR is credited to @dmos62 , who submitted these changes to my branch.

After @dmos62 finishes reviewing a fairly long chain of child branches (and they are merged), he will begin creating his own PRs.  We've agreed to start out this way to avoid merge conflicts between us, until the backlog of PR reviews/merges are reduced.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4322

-- Commit Summary --

  * Rename CoreWalletService -> CoreWalletsService
  * Add rpc wallet(s) protection tests
  * Add rpc method 'getfundingaddresses'
  * Replace duplicate code in getFundingAddresses
  * Add rpc method 'getaddressbalance'
  * Add rpc method 'createpaymentacct'
  * Call core wallets service methods from CoreApi
  * Factor duplicate unlocked wallet checks into new method
  * Replace Tuple3 with memoization
  * Merge pull request #2 from dmos62/Z-getfundingaddresses-patch
  * Refactor getFundingAddresses to use memoization
  * Rmove blank line

-- File Changes --

    M cli/src/main/java/bisq/cli/CliMain.java (81)
    M cli/test.sh (116)
    M core/src/main/java/bisq/core/grpc/CoreApi.java (63)
    A core/src/main/java/bisq/core/grpc/CorePaymentAccountsService.java (57)
    R core/src/main/java/bisq/core/grpc/CoreWalletsService.java (131)
    A core/src/main/java/bisq/core/grpc/GrpcPaymentAccountsService.java (46)
    M core/src/main/java/bisq/core/grpc/GrpcServer.java (26)
    R core/src/main/java/bisq/core/grpc/GrpcWalletsService.java (54)
    M proto/src/main/proto/grpc.proto (38)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4322.patch
https://github.com/bisq-network/bisq/pull/4322.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4322
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200618/b8d16081/attachment.html>