[bisq-network/bisq] Add rpc method 'getpaymentaccts' (#4323)
Stan
notifications at github.com
Fri Jun 19 15:51:31 UTC 2020
This PR addresses task 5 in issue [4257](https://github.com/bisq-network/bisq/issues/4257)
This new gRPC PaymentAccounts service method displays the user's stored payment accounts.
A unit test to check a successful return status code was added to cli/test.sh.
This PR should be reviewed/merged after PR [4322](https://github.com/bisq-network/bisq/pull/4322).
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/4323
-- Commit Summary --
* Rename CoreWalletService -> CoreWalletsService
* Add rpc wallet(s) protection tests
* Add rpc method 'getfundingaddresses'
* Replace duplicate code in getFundingAddresses
* Add rpc method 'getaddressbalance'
* Add rpc method 'createpaymentacct'
* Call core wallets service methods from CoreApi
* Factor duplicate unlocked wallet checks into new method
* Replace Tuple3 with memoization
* Merge pull request #2 from dmos62/Z-getfundingaddresses-patch
* Refactor getFundingAddresses to use memoization
* Rmove blank line
* Add rpc method 'getpaymentaccts'
-- File Changes --
M cli/src/main/java/bisq/cli/CliMain.java (99)
M cli/test.sh (121)
M core/src/main/java/bisq/core/grpc/CoreApi.java (63)
A core/src/main/java/bisq/core/grpc/CorePaymentAccountsService.java (57)
R core/src/main/java/bisq/core/grpc/CoreWalletsService.java (131)
A core/src/main/java/bisq/core/grpc/GrpcPaymentAccountsService.java (46)
M core/src/main/java/bisq/core/grpc/GrpcServer.java (26)
R core/src/main/java/bisq/core/grpc/GrpcWalletsService.java (54)
M proto/src/main/proto/grpc.proto (38)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/4323.patch
https://github.com/bisq-network/bisq/pull/4323.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4323
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200619/f58d1a94/attachment-0001.html>
More information about the bisq-github
mailing list