[bisq-network/bisq] Return protos from funding address methods (#4324)

[Stan]

The `getaddressbalance` and `getfundingaddresses` methods now send new `AddressBalanceInfo` proto messages instead of a formatted String to the client.  The `AddressBalanceInfo` message contains address string, balance, and # of confirmations (transaction confidence) fields.

Changes include:
* A new `AddressBalanceInfo` proto message
* A wrapper class for the new `AddressBalanceInfo` proto
* New `getaddressbalance` and `getfundingaddresses` signatures in server
* `AddressBalanceInfo` display logic in client
* Removal of balance formatting logic in server
* Refactoring of balance formatting logic in client

This PR should be reviewed/merged after PR [4323](https://github.com/bisq-network/bisq/pull/4323).

The first cut of these methods methods were hacked because of uncertainty about whether or not we were going to ditch gRPC for an exclusively RESTful API.  But it seems likely we will serve both kinds of clients from the gRPC server.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4324

-- Commit Summary --

  * Rename CoreWalletService -> CoreWalletsService
  * Add rpc wallet(s) protection tests
  * Add rpc method 'getfundingaddresses'
  * Replace duplicate code in getFundingAddresses
  * Add rpc method 'getaddressbalance'
  * Add rpc method 'createpaymentacct'
  * Call core wallets service methods from CoreApi
  * Factor duplicate unlocked wallet checks into new method
  * Replace Tuple3 with memoization
  * Merge pull request #2 from dmos62/Z-getfundingaddresses-patch
  * Refactor getFundingAddresses to use memoization
  * Rmove blank line
  * Add rpc method 'getpaymentaccts'
  * Return protos from funding address methods

-- File Changes --

    M cli/src/main/java/bisq/cli/CliMain.java (127)
    M cli/test.sh (121)
    M core/src/main/java/bisq/core/grpc/CoreApi.java (64)
    A core/src/main/java/bisq/core/grpc/CorePaymentAccountsService.java (57)
    R core/src/main/java/bisq/core/grpc/CoreWalletsService.java (112)
    A core/src/main/java/bisq/core/grpc/GrpcPaymentAccountsService.java (46)
    M core/src/main/java/bisq/core/grpc/GrpcServer.java (26)
    R core/src/main/java/bisq/core/grpc/GrpcWalletsService.java (64)
    A core/src/main/java/bisq/core/grpc/model/AddressBalanceInfo.java (43)
    M proto/src/main/proto/grpc.proto (44)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4324.patch
https://github.com/bisq-network/bisq/pull/4324.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4324
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200619/12804bc8/attachment.html>