[bisq-network/bisq] Add rpc method 'createpaymentacct' (#4308)

[dmos62]

@dmos62 requested changes on this pull request.



> +                }
+                case createpaymentacct: {
+                    if (nonOptionArgs.size() < 2)
+                        throw new IllegalArgumentException("no account name specified");
+
+                    var accountName = nonOptionArgs.get(1);
+
+                    if (nonOptionArgs.size() < 3)
+                        throw new IllegalArgumentException("no account number specified");
+
+                    var accountNumber = nonOptionArgs.get(2);
+
+                    if (nonOptionArgs.size() < 4)
+                        throw new IllegalArgumentException("no fiat currency specified");
+
+                    var fiatCurrencyCode = nonOptionArgs.get(3).toUpperCase();

`.toUpperCase()` seems misplaced here. It would soon get repetive. Whether the underlying logic differentiates between capitalizations is a low-level implementation detail and would do better at the lowest practical level.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4308#pullrequestreview-435055483
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200622/1e7de352/attachment.html>