[bisq-network/bisq] Add rpc method 'createpaymentacct' (#4308)

[dmos62]

@dmos62 commented on this pull request.



> +                    out.println(reply.getFundingAddressesInfo());
+                    return;
+                }
+                case createpaymentacct: {
+                    if (nonOptionArgs.size() < 2)
+                        throw new IllegalArgumentException("no account name specified");
+
+                    var accountName = nonOptionArgs.get(1);
+
+                    if (nonOptionArgs.size() < 3)
+                        throw new IllegalArgumentException("no account number specified");
+
+                    var accountNumber = nonOptionArgs.get(2);
+
+                    if (nonOptionArgs.size() < 4)
+                        throw new IllegalArgumentException("no fiat currency specified");

I'm not sure I follow. I'll try to rephrase. My concern here is that this behaviour is incorrect in some cases. Suppose you call `createpaymentacct` with arguments `account name`, `number` (`fiat currency` omitted). It will output `"no fiat currency specified"`, which is correct. But, if you call it with arguments `account name`, `fiat currency` (`account number` omitted), it will output `"no fiat currency specified"`, which is incorrect. Or am I mistaken?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4308#discussion_r444123797
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200623/86a03b33/attachment.html>