[bisq-network/bisq] Add rpc method 'getoffers' (#4329)

dmos62 notifications at github.com
Tue Jun 23 17:47:27 UTC 2020


@dmos62 commented on this pull request.



> +                            PaymentAccount paymentAccount,
+                            boolean useSavingsWallet,
+                            TransactionResultHandler resultHandler) {
+        coreOffersService.createOffer(offerId,
+                currencyCode,
+                direction,
+                price,
+                useMarketBasedPrice,
+                marketPriceMargin,
+                amount,
+                minAmount,
+                buyerSecurityDeposit,
+                paymentAccount,
+                useSavingsWallet,
+                resultHandler);
+    }

It took me a minute to realise that the difference between these methods is that one of them takes primitives and the other takes higher level abstractions. I'm leaving this comment as an annotation for myself.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4329#pullrequestreview-436016794
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200623/861bf39e/attachment.html>


More information about the bisq-github mailing list