[bisq-network/bisq] Add equals check to prevent resetting of newly set Filter (#4335)

Christoph Atteneder notifications at github.com
Thu Jun 25 10:48:36 UTC 2020

While testing #4294 I recognized that when adding a new filter object to the network one of my regtest nodes got its filter reset. This was caused by a timing issue that the added filter message was received before the removed filter message. In that case the filter was reset and the new filter never applied. This is only a problem during runtime when a new filter is set. After a restart the correct filter is applied. This PR adds a equals check to prevent the reseting of a filter by mistake. As the added filter message overwrites all fields anyways not having the removed filter message is not essential.
You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * Add equals check to prevent resetting of newly set Filter

-- File Changes --

    M core/src/main/java/bisq/core/filter/FilterManager.java (3)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200625/e1dbee60/attachment.html>

More information about the bisq-github mailing list