[bisq-network/bisq] Deposit improvements (#4347)

sqrrm notifications at github.com
Tue Jun 30 17:07:53 UTC 2020


<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->

Implements suggestion in https://github.com/bisq-network/proposals/issues/233#issuecomment-650780056

Increased visibility of security deposit in offer overview.

Set suggested deposit to double of trade range over the trade period.

Both traders have the same security deposit.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4347

-- Commit Summary --

  * Add deposit column to OfferBookView
  * Move locktime definition to Restrictions
  * Suggest security deposit depending on previous volatility
  * Use same security deposit for buyer and seller
  * Update security deposit info text at offer creation
  * Fix deposit column layout

-- File Changes --

    M common/src/main/java/bisq/common/util/MathUtils.java (25)
    M core/src/main/java/bisq/core/btc/wallet/Restrictions.java (5)
    M core/src/main/java/bisq/core/offer/CreateOfferService.java (7)
    M core/src/main/java/bisq/core/offer/OpenOfferManager.java (4)
    M core/src/main/java/bisq/core/trade/protocol/tasks/maker/MakerSetsLockTime.java (3)
    M core/src/main/java/bisq/core/user/Preferences.java (3)
    M core/src/main/resources/i18n/displayStrings.properties (3)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferDataModel.java (65)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java (19)
    M desktop/src/main/java/bisq/desktop/main/offer/createoffer/CreateOfferDataModel.java (3)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookView.java (51)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookViewModel.java (11)
    M desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModel.java (3)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4347.patch
https://github.com/bisq-network/bisq/pull/4347.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4347
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200630/189a189e/attachment-0001.html>


More information about the bisq-github mailing list