[bisq-network/bisq] Update offer address on clean (#4021)

Florian Reimair notifications at github.com
Mon Mar 2 14:52:34 UTC 2020


<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->

motivated by https://github.com/bisq-network/bisq/issues/3995

When the hiddenservice address changes, offers now get updated to the new address before republishing. If there are open trades, they will still fail but at least there are no faulty offers out there anymore. Plus, a user might wonder why nobody takes his offers.

Happens if Bisq silently starts a fresh hiddenservice. Reasons for that to happen might be:
- hidden service files get damaged ([example](https://bisq.community/t/failed-to-decode-rsa-key/8961))
- antivirus software deleting hidden service files
- https://github.com/bisq-network/bisq/issues/3884
- support tells them to do so to fix network connectivity issues

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4021

-- Commit Summary --

  * Move protocol version update
  * Move capabilities update
  * Added node address update

-- File Changes --

    M core/src/main/java/bisq/core/offer/OpenOfferManager.java (43)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4021.patch
https://github.com/bisq-network/bisq/pull/4021.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4021
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200302/72e36e1b/attachment.html>


More information about the bisq-github mailing list