[bisq-network/bisq] Configuring custom Bitcoin node in GUI settings by IPv6 address fails (#3990)

[James Cox]

The comma separated IP addresses from --btcNodes configuration are being parsed by the following routine, which is failing for IPv6:

        public static BtcNode fromFullAddress(String fullAddress) {
            String[] parts = fullAddress.split(":");
            checkArgument(parts.length > 0);
            final String host = parts[0];
            int port = DEFAULT_PORT;
            if (parts.length == 2)
                port = Integer.valueOf(parts[1]);

            return host.contains(".onion") ? new BtcNode(null, host, null, port, null) : new BtcNode(null, null, host, port, null);
        }

The code expects a colon separating address from port so the address above evaluates to `[2401`  and port  evaluates to `8333` from `DEFAULT_PORT`.

Having discussed with @wiz, there's another scenario to look into which is **rpcHost** configuration that does accept IPv6.  I'll look into that an see how it's parsing IPv6 addresses.

Please consider me to be working on a PR for this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3990#issuecomment-596166147
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200307/23ee9524/attachment.html>