[bisq-network/bisq-website] Fix Opengraph and Twitter tags (#320)

wiz notifications at github.com
Mon Mar 9 18:39:26 UTC 2020


wiz commented on this pull request.



>          <meta property="twitter:title" content="{{ page.title }}">
         <meta property="twitter:card" content="summary_large_image">
-        <meta property="twitter:site" content="{{ langdata.enabled }}">
+        <meta property="twitter:site" content="https://bisq.network/">
+        <meta property="twitter:description" content="{{ langdata.site_desc }}">
+        <meta property="twitter:image" content="/images/bisq-og.jpg">

> Twitter cards do not support relative paths, and you have to use a fully-qualified HTTP(S) URL in the image tag.

<img width="495" alt="Screen Shot 2020-03-10 at 3 35 23" src="https://user-images.githubusercontent.com/232186/76246173-8b434900-6280-11ea-8a20-e5dd26d8a3ae.png">

Good job "fixing" the twitter tag, did you guys even test this? lol
The twitter card preview image is broken now :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-website/pull/320#pullrequestreview-371434731
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200309/c23ab712/attachment.html>


More information about the bisq-github mailing list