[bisq-network/bisq] Bisq does not add "dust" outputs to miner fee (#4039)

[wiz]

### Background

According to Bitcoin consensus rules, no output can be less than 546 sats. If a transaction with such an output is broadcast, it will be rejected.

### Description

Bisq attempts to broadcast Bitcoin transactions containing "dust" outputs, instead of simply adding the dust to the miner fee like most wallets do.

#### Version

v1.2.7

### Steps to reproduce

This is the difficult part, as users randomly do this if their transaction coincidentally results in an output of less than 546 sats. However, since Bisq assumes transactions it creates are valid (without checking the dust rule), this results in triggering other random Bisq issues. Sometimes it results in a failed trade, sometimes it results in a corrupted wallet.

### Expected behaviour

The dust output should not be created, and instead added to fees.

### Actual behaviour

The dust output is created, and the Bitcoin transaction is rejected, causing further issues in Bisq depending on the situation.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/4039
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200309/6295e395/attachment.html>