[bisq-network/bisq] Make serialisation in FileManager::saveToFile thread-safe (#4025)

Manfred Karrer notifications at github.com
Tue Mar 10 18:59:11 UTC 2020


@stejbac Thanks for the implementation of the suggested changes!

Could we make a list of all potential persisted objects (some are only created in rare cases like FailedTrades) to check for each persisted object if the adequate interface is applied? Would be also great to see a performance comparison before/after change (hope I don't get too annoying with those requests but I think its a bit risky change we better to be extra careful here). 

I just found another issue (no serious problem but risk for future problems):
`VoteWithProposalTxIdList` is extending `PersistableList` which is now using the `UserThreadMappedPersistableEnvelope`. This list is using the PersistableList only for serialisation but not real persistence (see comment in class). This should be fixed anyway by a more correct style (e.g. using a dedicated List only for that purpose). As we don't call the `toPersistableMessage` method here no behaviour change is introduced, but if anyone would start further changes we might inherit a potential critical change, which can easily lead to a consensus problem. I suggest to clean that up either with the PR (or better with a new one) so that this risk by abusing the `PersistableList` here is removed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4025#issuecomment-597257119
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200310/2cfcf355/attachment.html>


More information about the bisq-github mailing list