[bisq-network/bisq] Make serialisation in FileManager::saveToFile thread-safe (#4025)

Steven Barclay notifications at github.com
Wed Mar 11 00:10:18 UTC 2020


Earlier, I (manually) worked out a type hierarchy of everything extending / implementing `PersistableEnvelope` after the proposed changes:

![Screenshot from 2020-03-11 07-23-24](https://user-images.githubusercontent.com/54855381/76367873-53640080-6369-11ea-93e4-944cbb6e46f9.png)
(Actuallty `PersistableList` isn't an abstract class, but probably could be.)

I was intending to clean up the classes incorrectly implementing `PersistableEnvelope` in a separate PR, as suggested.

It looks like every `toProtoMessage` and `fromProto` method of each class in the DAO package extending `PersistableList` collects items into a new list using a stream, anyway, when mapping the input list items to/from _proto.*_ objects. So I would have thought that only the iteration order of the `PersistableList.getList()` items matters for proto conversion.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4025#issuecomment-597380012
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200310/883c60e1/attachment-0001.html>


More information about the bisq-github mailing list