[bisq-network/bisq] Make serialisation in FileManager::saveToFile thread-safe (#4025)

Manfred Karrer notifications at github.com
Wed Mar 11 01:16:38 UTC 2020

Thanks for the list. 
Regarding `VoteWithProposalTxIdList` and `MeritList`: Yes I also assume there is not issue but I think its more safe to use a dedicated class to avoid potential future issues. Those classed implement also the `ConsensusCritical` which marks classed critical to consensus. 

Also the `PersistableNetworkPayloadList` and its related classes (`PersistableNetworkPayloadListService`) could be cleaned up and removed (in separate PR). It was long ago used for converting db files. 
`PersistableHashMap` is also not used.

Thanks again for working on that!

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200310/3e007084/attachment.html>

More information about the bisq-github mailing list