[bisq-network/bisq] Fixed wrongly removing listeners (#4050)
Florian Reimair
notifications at github.com
Wed Mar 11 16:35:43 UTC 2020
<!--
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->
Fixes https://github.com/bisq-network/bisq/issues/2779
This is a 2 part fix:
- [x] prevent listener from being removed
- [ ] keep changes to EditOfferView even when navigating elsewhere
<details>
the second one is trickier, that is what I got so far:
- when switching to another tab of the main toolbar and returning, `MutableOfferView:activate` gets called from outside. When negating the "if", values are kept.
- however, once that works and you switch to another subtab and back, everything is reset again
</details>
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/4050
-- Commit Summary --
* Fixed wrongly removing listeners
-- File Changes --
M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferView.java (3)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/4050.patch
https://github.com/bisq-network/bisq/pull/4050.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4050
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200311/b6311411/attachment-0001.html>
More information about the bisq-github
mailing list