[bisq-network/bisq] Limit number of unconfirmed offers (#4053)

[Florian Reimair]

<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->

Fixes https://github.com/bisq-network/bisq/issues/3705

It seems that Bisq can reach a critical mass of unconfirmed transactions. Exceeding this mass causes all sorts of failures. In the corresponding issue it has been suggested to just limit the number of unconfirmed transactions.

Here is an attempt to do so. At least for offers.

To all the experts out there, here are some points to be discussed
- does this "hard limit" only affect offers (I guess the fee txs) or does it affect all txs
- is that something to be fixed in bitcoinj?


Please note that I am no expert in the BTC parts of the Bisq code plus the PR is currently largely untested. It is just there to get things moving.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4053

-- Commit Summary --

  * Limit number of unconfirmed offers

-- File Changes --

    M core/src/main/java/bisq/core/offer/placeoffer/PlaceOfferProtocol.java (2)
    A core/src/main/java/bisq/core/offer/placeoffer/tasks/CheckNumberOfUnconfirmedTransactions.java (18)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4053.patch
https://github.com/bisq-network/bisq/pull/4053.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4053
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200312/c9a11933/attachment.html>