[bisq-network/bisq] Give LocalBitcoinNode a timeout in case BitcoinJ hangs during handshake attempt (#4058)

sqrrm notifications at github.com
Fri Mar 13 16:48:56 UTC 2020


I think, like @ripcurlx, that we should merge this PR since it's fixing something that's wrong in the current code base. If we decide to not release the local bitcoin node detection we'll make a separate revert commit later on. I won't merge until at least one more person gives an ACK or @wiz changes his mind though.

@wiz this PR doesn't affect the inclusion of local bitcoin node in the next release. If that's your reason for NACK I think that's the wrong way to suggest reverting the entire feature.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4058#issuecomment-598816286
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200313/35b132a1/attachment-0001.html>


More information about the bisq-github mailing list