[bisq-network/bisq] Give LocalBitcoinNode a timeout in case BitcoinJ hangs during handshake attempt (#4058)

[dmos62]

> @dmos62 When running with a local full node I recognized that I always the following exception log in the console:
> 
> ```
> März-14 11:54:29.683 [NioClientManager] WARN  o.b.net.ConnectionHandler: Error handling SelectionKey: java.nio.channels.CancelledKeyException  java.nio.channels.CancelledKeyException: null
> 	at java.base/sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:73)
> 	at java.base/sun.nio.ch.SelectionKeyImpl.readyOps(SelectionKeyImpl.java:87)
> 	at java.base/java.nio.channels.SelectionKey.isWritable(SelectionKey.java:310)
> 	at org.bitcoinj.net.ConnectionHandler.handleKey(ConnectionHandler.java:229)
> 	at org.bitcoinj.net.NioClientManager.handleKey(NioClientManager.java:86)
> 	at org.bitcoinj.net.NioClientManager.run(NioClientManager.java:122)
> 	at com.google.common.util.concurrent.AbstractExecutionThreadService$1$2.run(AbstractExecutionThreadService.java:66)
> 	at com.google.common.util.concurrent.Callables$4.run(Callables.java:122)
> 	at org.bitcoinj.utils.ContextPropagatingThreadFactory$1.run(ContextPropagatingThreadFactory.java:49)
> 	at java.base/java.lang.Thread.run(Thread.java:844)
> 
> java.nio.channels.CancelledKeyException: null
> 	at java.base/sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:73)
> 	at java.base/sun.nio.ch.SelectionKeyImpl.readyOps(SelectionKeyImpl.java:87)
> 	at java.base/java.nio.channels.SelectionKey.isWritable(SelectionKey.java:310)
> 	at org.bitcoinj.net.ConnectionHandler.handleKey(ConnectionHandler.java:229)
> 	at org.bitcoinj.net.NioClientManager.handleKey(NioClientManager.java:86)
> 	at org.bitcoinj.net.NioClientManager.run(NioClientManager.java:122)
> 	at com.google.common.util.concurrent.AbstractExecutionThreadService$1$2.run(AbstractExecutionThreadService.java:66)
> 	at com.google.common.util.concurrent.Callables$4.run(Callables.java:122)
> 	at org.bitcoinj.utils.ContextPropagatingThreadFactory$1.run(ContextPropagatingThreadFactory.java:49)
> 	at java.base/java.lang.Thread.run(Thread.java:844)
> ```
> 
> The connection is established successfully to the node, but I did get this exception.

Those should be some of the expected exceptions I have not muted. I'll double check and submit PR to mute them.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4058#issuecomment-599042648
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200314/31d2cc99/attachment.html>