[bisq-network/bisq] Mute unnecessary logging and minor improvements (#4062)

Christoph Atteneder notifications at github.com
Sun Mar 15 10:49:43 UTC 2020


ripcurlx requested changes on this pull request.

NACK

I just tested it on Mainnet with and without a local Bitcoin Core.
Running a well configured Bitcoin Core everything looks fine, but when I start the node as a light client without a Bitcoin Core running I'll always get this warning log:
```
März-15 11:44:21.452 [JavaFX Application Thread] ERROR b.c.btc.nodes.LocalBitcoinNode: Exploratory handshake attempt with a local Bitcoin node (that may not be there) unexpectedly timed out. This should never happen; please report this. Continuing as if a local BTC node was not found. 
```
If that will be triggered all the time no matter if there is a local bitcoin core node running or not, I think the text should be changed, that this is expected if no local BTC node is running on this system.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4062#pullrequestreview-374788448
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200315/f78344b7/attachment.html>


More information about the bisq-github mailing list