[bisq-network/bisq] Mute unnecessary logging and minor improvements (#4062)

dmos62 notifications at github.com
Sun Mar 15 18:28:53 UTC 2020


@ripcurlx that log error is about BitcoinJ hanging, which is not normal. I've not experienced this. @wiz reported this first, but in his case it was when a local BTC node wasn't running. You experiencing it when there is a local BTC node running is troubling.

Could you clarify your second comment? Did the bug go away on its own?

Starting to think this implementation is cursed. The bright side is that if we generalize configuration checking to remote nodes as well, we'll be able to do away with all this additional IO. I've realised that this implementation turned out like an awkward appendage, because I felt intimidated hooking into Bisq's regular BTC networking. A lot would have been simpler.

What's kind of troubling is that if LocalBitcoinNode's usage of BitcoinJ is not somehow incorrect, these weird BitcoinJ hangs might be happening in other parts of Bisq too.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4062#issuecomment-599246847
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200315/08be2341/attachment.html>


More information about the bisq-github mailing list