[bisq-network/bisq] fix #3818 .. sorting range amounts appropriately by min/max (#4068)
James Cox
notifications at github.com
Mon Mar 16 14:08:38 UTC 2020
Fixes #3818
This change fixes an issue with sorting the offer list when the amount is shown as a range. The sort was hard coded on the top end of the range which does not make sense when sorting in ascending order.
In OfferBookView::activate() we add a listener for the sortTypeProperty on amountColumn and volumeColumn. When the sortType is changed we set the comparator to be the approprate property of the Offer; either getAmount/getMinAmount; getVolume/getMinVolume.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/4068
-- Commit Summary --
* fix #3818 .. sorting range amounts appropriately by min/max
-- File Changes --
M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookView.java (25)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/4068.patch
https://github.com/bisq-network/bisq/pull/4068.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4068
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200316/49e089e1/attachment.html>
More information about the bisq-github
mailing list