[bisq-network/bisq] Allow IPv6 connections to Bitcoin nodes (#4045)

wiz notifications at github.com
Mon Mar 16 15:56:38 UTC 2020


wiz requested changes on this pull request.

NACK

Test case 1 failed:
1) Set btcnode configuration to `node100.wiz.network,node130.wiz.network,node140.wiz.network,node150.wiz.network`
Expected) Seeing IPv6 addresses in settings -> network status
Actual) Seeing IPv4 addresses in settings -> network status

Test case 2 failed:
1) Set btcnode configuration to `2401:b140::42:100,2401:b140::42:130,2401:b140::42:140,2401:b140::42:150`
Expected) Connects to IPv6 btcnodes
Actual) Bisq fails to start due to "invalid configuration"



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4045#pullrequestreview-375351877
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200316/506ece19/attachment.html>


More information about the bisq-github mailing list