[bisq-network/bisq] Bisq creates an invalid timelock payout transaction in certain circumstances (#4071)

[wiz]

### Description

Bisq creates an invalid timelock payout transaction in certain circumstances

#### Version

v1.2.4

### Steps to reproduce

Still investigating.

### Expected behaviour

Payout TX is valid and can be broadcast to the Bitcoin network anytime after the lock_time.

### Actual behaviour

Payout TX is rejected by the Bitcoin network for "bad-txns-in-belowout" error, which means the sum of the outputs is greater than the sum of the inputs.

#### Device or machine

Linux

#### Additional info

A user requested support for a closed trade which should have been donated to the Bisq donation address, but was never donated. After manually dumping the payout TX, I found it was invalid due to the following outputs > inputs. Perhaps an input is missing from the calculation

```
    "inputs": [
        {
...
            "output_value": 7753800, 
...
       }
    ], 
    "outputs": [
        {
            "addresses": [
                "3EtUWqsGThPtjwUczw27YCo6EWvQdaPUyp"
            ], 
...
            "value": 8750000
        }
    ], 
```


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/4071
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200317/bfd520e0/attachment.html>