[bisq-network/bisq] Allow IPv6 connections to Bitcoin nodes (#4045)

James Cox notifications at github.com
Tue Mar 17 16:10:08 UTC 2020


jmacxx commented on this pull request.



> +
+        // #3990 allow IPv6 custom Bitcoin node in settings by hostname
+        System.setProperty("java.net.preferIPv6Addresses", "true");

I have not seen any drawback from setting this, even if IPv6 is not available.  Here's a [document](https://docs.oracle.com/javase/1.5.0/docs/guide/net/ipv6_guide/index.html) on the subject, which mentions setting the property.  And [another one](https://stackoverflow.com/questions/20262587/where-to-set-java-net-preferipv6addresses-true#20262705) which mentions that the setting has to be made very early in app startup.

If you think its too risky we can revert to choosing between IPv4 and IPv6 addresses in BtcNodeConverter where it creates a PeerAddress from hostname.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4045#discussion_r393795357
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200317/80c1e002/attachment.html>


More information about the bisq-github mailing list