[bisq-network/bisq] Bisq stalls for 10 seconds while starting during Bitcoin node detection if firewall enabled (#4073)

[Christoph Atteneder]

@dmos62 I have the feeling the fixing of the wrong used `detected` value before that is now solved  automatically by the `null` check might cause this issue. 
https://github.com/bisq-network/bisq/blob/fdc17e90eb2992e119ca8d0a5a82b9fa7c0afd6b/core/src/main/java/bisq/core/btc/nodes/LocalBitcoinNode.java#L71-L76
We have fixed the issue that it defaulted back then to `true` without having the detection set, but this change might cause other issues. I think that is also the reason why at following code part the local bitcoin flag is checked again.
https://github.com/bisq-network/bisq/blob/fdc17e90eb2992e119ca8d0a5a82b9fa7c0afd6b/core/src/main/java/bisq/core/app/BisqSetup.java#L548-L550

Maybe the safer solution would be to update the `useTorForBTC` in the WalletSetup after doing the first detection during the Bisq startup sequence introducing again at step2 the local bitcoin node check. What do you think?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/4073#issuecomment-600548547
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200318/fecceaf2/attachment.html>