[bisq-network/bisq] [WIP] Check BTC node config without IO overhead (#4081)

[dmos62]

This is a proof of concept for checking BTC node's configuration. It's an alternative approach to what I had proposed earlier (that was merged and reverted due to reliability issues). In contrast to the previous attempt, this approach doesn't incur additional IO and doesn't use blocking. Whereas the previous attempt initiated a short lived BitcoinJ connection to a node, this approach just listens into the connections we are already establishing. Also, while previously the checking applied only to a local BTC node, this approach generalizes checking to all BTC nodes we connect to.

Currently, it has two problems:

a) connecting to a pruning node, on my setup at least, causes the connection to crash, and the listener never gets triggered; this is a rare BitcoinJ edge case bug and I opened an issue for it https://github.com/bisq-network/bisq/issues/4080 ;

and, b) this WIP implementation just does `peer.close()`, which causes the PeerGroup to just retry the connection, in case we're in local mode, or possibly retry later in case we're in non-local mode (didn't explore non-local behaviour yet); I'm pondering if this is indeed undesirable or if we would want to use this to get free auto-retry.

Another open question is what to do in case a remote node is found to be misconfigured. Just an error log?
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4081

-- Commit Summary --

  * [WIP] Check BTC node config without overhead

-- File Changes --

    M core/src/main/java/bisq/core/btc/setup/WalletsSetup.java (84)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4081.patch
https://github.com/bisq-network/bisq/pull/4081.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4081
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200321/149eeebc/attachment.html>