[bisq-network/bisq] Upgrade firebase-admin, avoid gRPC version conflict (#4088)

Stan notifications at github.com
Sat Mar 21 23:15:21 UTC 2020


The latest firebase-admin (v6.12.2) depends on grpc-api v1.24.1,
which is as close as we can get to the grpc v1.25.0 specified in
build.gradle.  Currently, the firebase-admin version requirement
is causing the build to download grpc v1.10.1 jars, but at runtime,
grpc 1.25.0 jars are loaded.

Eliminating the version conflict saves a dev time thinking about which
source jar to choose from while examining exception stack traces.

Partial fix for #4086

<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4088

-- Commit Summary --

  * Upgrade firebase-admin, avoid gRPC version conflict

-- File Changes --

    M build.gradle (8)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4088.patch
https://github.com/bisq-network/bisq/pull/4088.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4088
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200321/13701751/attachment.html>


More information about the bisq-github mailing list