[bisq-network/bisq] Bisq does not verify taker's funding TX is broadcast to Bitcoin P2P network (#3489)

[chimp1984]

The trade protocol must not be delayed by the API call as that would just introduce more problems like network disconnections or timeouts. It would also decrease UX. 

I recommend to do that API lookup after a certain period and then display a waring to the user. 

The cases if "too long unconfirmed tx chain" can be handled differently by limiting the offer to be created or offers taken by the number of unconfirmed transactions in the users wallet. That is not perfect and does not handle all possible cases but I think that will reduce those issues by > 90% and is relatively easy to implement and does not cause UX issues for most users (only those who create many offers in a row which is not a standard behaviour).

Also note that trades with "too long unconfirmed tx chain" still can be confirmed later and the trade can be completed normally. 

SPV resync have to been taken carefully. It can cause more harm as it helps, for instance if a tx does not get confirmed fast but would have been confirmed in a few hours a SPV resync of one trader will render the deposit tx invalid if that user makes a double spend in the meantime. Then the other user has a failed deposit tx and require a SPV resync as well.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3489#issuecomment-602352803
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200322/998bcb8a/attachment.html>