[bisq-network/bisq] Prevent dust outputs from being created during withdraw from wallet (#4093)

[James Cox]

This change fixes an issue whereby dust change outputs are inadvertently created when users make withdrawals from their wallets.  (Funds -> Send Funds)

The solution taken here is to detect a dust TXO during the withdrawal fee estimation process and add that amount to the fee thus eliminating the dust output.  

For example if the user has 1 BTC and goes to withdraw 0.99999900 BTC it will detect a change TXO of 100 sats which is below the dust limit, increase the fee by 100 sats and therefore withdraw 1 BTC.

This fix only applies to user withdrawals from their wallet.  Other use cases such as P2P trading, deposits and fees will be handled separately.

Related to #4039
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4093

-- Commit Summary --

  * Remove dust outputs created during withdraw from wallet

-- File Changes --

    M desktop/src/main/java/bisq/desktop/main/funds/withdrawal/WithdrawalView.java (17)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4093.patch
https://github.com/bisq-network/bisq/pull/4093.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4093
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200324/827e6b6f/attachment.html>