[bisq-network/bisq] Move command & core proto defs to new subproject (#4096)

Stan notifications at github.com
Thu Mar 26 13:29:26 UTC 2020


Protobuf definition files were moved from common and core to a new
protodefinition subproject.

The two main reasons for doing this are to speed up builds by not
having to regenerate common and core protobuf classes
every time a change is made in those subprojects, and to remove
the grpc cli's direct dependency on core and the transitive dependency
on common.

In order to accomplish this, cli's BisqCliMain was stripped of
its dependencies on common and core.  Cli can only get the version
and balance now.

gRPC stub boilerplate was moved from BisqCliMain to a CliCommand
class to avoid some of the bloat that is going to happen as the
read-response loop supports more rpc commands.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4096

-- Commit Summary --

  * Move command & core proto defs to new subproject

-- File Changes --

    M build.gradle (126)
    M cli/src/main/java/bisq/cli/app/BisqCliMain.java (223)
    A cli/src/main/java/bisq/cli/app/CliCommand.java (72)
    A cli/src/main/resources/logback.xml (17)
    M core/src/main/java/bisq/core/grpc/BisqGrpcServer.java (24)
    M daemon/src/main/java/bisq/daemon/app/BisqDaemonMain.java (2)
    R protodefinition/src/main/proto/grpc.proto (2)
    R protodefinition/src/main/proto/pb.proto (0)
    M settings.gradle (1)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4096.patch
https://github.com/bisq-network/bisq/pull/4096.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4096
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200326/12392a63/attachment.html>


More information about the bisq-github mailing list