[bisq-network/bisq] Move command & core proto defs to new subproject (#4096)
notifications at github.com
Thu Mar 26 16:49:33 UTC 2020
@cbeams approved this pull request.
ACK, please see my two review commits.
I didn't mention this in the commit comments, but I also removed the FIXMEs from grpc.proto about IDEA complaining about not having references to imported proto definitions from pb.proto. I'm not getting any errors any more, and I can navigate from grpc.proto to pb.proto by clicking, e.g. `CMD-B` on the imported definition. Find Usages on, e.g. the `TradeStatistics2` proto def shows its usage in grpc.proto, etc, so I think everything is working as expected. This is probably because of some bug fix in a recent version of the IDEA protobuf plugin.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the bisq-github