[bisq-network/bisq] Prevent dust outputs from being created during withdraw from wallet (#4093)
James Cox
notifications at github.com
Fri Mar 27 03:18:33 UTC 2020
@jmacxx commented on this pull request.
> @@ -330,8 +331,9 @@ private void onWithdraw() {
feeEstimationTransaction = walletService.getFeeEstimationTransactionForMultipleAddresses(fromAddresses, sendersAmount);
}
checkNotNull(feeEstimationTransaction, "feeEstimationTransaction must not be null");
- Coin fee = feeEstimationTransaction.getFee();
- sendersAmount = feeExcluded ? amountAsCoin.add(fee) : amountAsCoin;
+ Coin dust = getDust(feeEstimationTransaction);
+ Coin fee = feeEstimationTransaction.getFee().add(dust);
+ sendersAmount = feeExcluded ? amountAsCoin.add(fee) : amountAsCoin.add(dust);
:+1: @sqrrm your suggestions sound great, I am working on implementing them!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4093#discussion_r399013243
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200326/6bd4c569/attachment.html>
More information about the bisq-github
mailing list