[bisq-network/bisq] Prevent dust outputs from being created during withdraw from wallet (#4093)

James Cox notifications at github.com
Sun Mar 29 02:34:13 UTC 2020

@jmacxx commented on this pull request.

> @@ -330,8 +331,9 @@ private void onWithdraw() {
                     feeEstimationTransaction = walletService.getFeeEstimationTransactionForMultipleAddresses(fromAddresses, sendersAmount);
                 checkNotNull(feeEstimationTransaction, "feeEstimationTransaction must not be null");
-                Coin fee = feeEstimationTransaction.getFee();
-                sendersAmount = feeExcluded ? amountAsCoin.add(fee) : amountAsCoin;
+                Coin dust = getDust(feeEstimationTransaction);
+                Coin fee = feeEstimationTransaction.getFee().add(dust);
+                sendersAmount = feeExcluded ? amountAsCoin.add(fee) : amountAsCoin.add(dust);

> adding a notice to the user that dust might be padded to the fee

I propose the following message in cases where dust is detected (shown in the following screenshot at the top of the popup):


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200328/ebabc038/attachment.html>

More information about the bisq-github mailing list