[bisq-network/bisq] Remove read stdin loop (#4097)

Chris Beams notifications at github.com
Mon Mar 30 08:15:18 UTC 2020

@cbeams commented on this pull request.

     public static void main(String[] args) {
-        new BisqCliMain("localhost", 8888);
+        new BisqCliMain("localhost", 8888, args);

        new BisqCliMain("localhost", 9998, args);

8888 is a poor number as it's frequently used by other services. 9998 fits with bisq's p2p port of 9999 and follows suit with bitcoind's 8333 p2p port and 8332 rpc port. I realize you did not introduce this change and that it's somewhat out of scope for this PR, but please make it anyway.

@freimair, please note that the choice of 9998 here overlaps with the same port used in `monitor/src/main/java/bisq/monitor/metric/TorHiddenServiceStartupTime.java`. Please consider changing that to something else if you see it being a conflict.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200330/02408a17/attachment.html>

More information about the bisq-github mailing list