[bisq-network/bisq] Prevent dust outputs from being created during withdraw from wallet (#4093)

sqrrm notifications at github.com
Mon Mar 30 10:21:26 UTC 2020

@sqrrm commented on this pull request.

> @@ -330,8 +331,9 @@ private void onWithdraw() {
                     feeEstimationTransaction = walletService.getFeeEstimationTransactionForMultipleAddresses(fromAddresses, sendersAmount);
                 checkNotNull(feeEstimationTransaction, "feeEstimationTransaction must not be null");
-                Coin fee = feeEstimationTransaction.getFee();
-                sendersAmount = feeExcluded ? amountAsCoin.add(fee) : amountAsCoin;
+                Coin dust = getDust(feeEstimationTransaction);
+                Coin fee = feeEstimationTransaction.getFee().add(dust);
+                sendersAmount = feeExcluded ? amountAsCoin.add(fee) : amountAsCoin.add(dust);

@m52go could you have a look at the user facing language. We're trying to avoid confusion and I feel I might be too deep here to have a good judgement of what a normal user will find helpful and what's just adding to extra confusion.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200330/458fea8d/attachment.html>

More information about the bisq-github mailing list