[bisq-network/bitcoinj] Permit listening to version messages (#35)

dmos62 notifications at github.com
Mon Mar 30 13:47:46 UTC 2020


Dependant PR: https://github.com/bisq-network/bisq/pull/4081

Commit message for commit titled "Add listener for when a VersionMessage is received" explaining the purpose of this commit and the PR in general:

```
Since Bisq requires nodes with specific configuration (as reflected in
their version messages), we also want to handle misconfigured nodes,
especially in cases where the user expects that node to be used. To get
access to all received version messages, a new listener is introduced.
Existing listeners are not sufficient, because in some cases BitcoinJ
will kill the Peer (connection to a node) before any of them are
triggered. This listener will always be triggered when a VersionMessage
is received.
```

In total, this PR introduces a bugfix (Permit alerts during handshake, see https://github.com/bisq-network/bisq/issues/4080), a compilation breaking fix (Fix javadoc compilation on JDK 11), a new listener (Add listener for when a VersionMessage is received) and bumps the version number (`0.14.7.bisq.1-SNAPSHOT` -> `0.14.7.bisq.2-SNAPSHOT`).

It should be noted that there is a failing test (not resulting from this PR): `ChannelConnectionTest.testChannelResume:459->roundTripClientWallet:551 ยป IllegalState`.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bitcoinj/pull/35

-- Commit Summary --

  * Permit alerts during handshake
  * Fix javadoc compilation on JDK 11
  * Add listener for when a VersionMessage is received
  * Bump version number

-- File Changes --

    M core/pom.xml (2)
    M core/src/main/java/org/bitcoinj/core/Peer.java (34)
    M core/src/main/java/org/bitcoinj/core/PeerGroup.java (73)
    M core/src/main/java/org/bitcoinj/core/VersionMessage.java (10)
    A core/src/main/java/org/bitcoinj/core/listeners/VersionMessageReceivedEventListener.java (34)
    M examples/pom.xml (2)
    M pom.xml (3)
    M tools/pom.xml (2)

-- Patch Links --

https://github.com/bisq-network/bitcoinj/pull/35.patch
https://github.com/bisq-network/bitcoinj/pull/35.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bitcoinj/pull/35
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200330/60eea90a/attachment.html>


More information about the bisq-github mailing list