[bisq-network/bisq] Check BTC node config without IO overhead (#4081)
notifications at github.com
Mon Mar 30 14:33:57 UTC 2020
This PR now depends on this PR on our BitcoinJ fork: https://github.com/bisq-network/bitcoinj/pull/35. For development I used a BitcoinJ build from a local Maven repository. When that PR for BitcoinJ is merged, relevant changes to `build.gradle` should be made here.
![user provided node misconfigured](https://user-images.githubusercontent.com/2715476/77923522-d90d0900-72a2-11ea-8131-095b57e376b6.png)
As seen in the screenshot, we're not providing a button to revert to not using a user-provided node (don't see how that can be done easily). The reason why before we could offer that option is that we were blocking on the check and we were only handling the local bitcoin node.
It can also be seen that Bisq is actually loaded, and after you click "shutdown" the informational local BTC node popup will appear briefly before Bisq closes.
In the background, the misconfigured peers are not explicitly closed (BitcoinJ closes them automatically if they're pruning). The errors are logged and if custom BTC nodes are used, or a local BTC node, the above error popup locks the user out.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the bisq-github