[bisq-network/bisq] Prevent dust outputs from being created during the trade process (#4094)

James Cox notifications at github.com
Mon Mar 30 14:34:01 UTC 2020

@jmacxx commented on this pull request.

> @@ -257,6 +260,7 @@ public Transaction completeBsqTradingFeeTx(Transaction preparedBsqTx,
         checkNotNull(wallet, "Wallet must not be null");
         Transaction resultTx = sendRequest.tx;
+        removeDust(resultTx);

@sqrrm From what I've seen there is existing code which checks the BSQ for dust before building the transaction (see https://github.com/bisq-network/bisq/issues/3688).  The `removeDust` insertion here looks at the transaction after it is built, just before broadcasting, to remove any dust change BTC.  I will look more into how it works though.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200330/46b99ec1/attachment-0001.html>

More information about the bisq-github mailing list