[bisq-network/bisq] Prevent dust outputs from being created during the trade process (#4094)
sqrrm
notifications at github.com
Mon Mar 30 16:42:52 UTC 2020
@sqrrm commented on this pull request.
> @@ -257,6 +260,7 @@ public Transaction completeBsqTradingFeeTx(Transaction preparedBsqTx,
checkNotNull(wallet, "Wallet must not be null");
wallet.completeTx(sendRequest);
Transaction resultTx = sendRequest.tx;
+ removeDust(resultTx);
It's possible the check during tx build is not there but rather later, causing it to look like a bug. Still, that's at least better than burning BSQ unwittingly. If you could check that it's handled properly and not as a bug report that would be best of course.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4094#discussion_r400337117
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200330/9746d9e6/attachment.html>
More information about the bisq-github
mailing list