[bisq-network/bisq] Prevent dust outputs from being created during the trade process (#4094)
James Cox
notifications at github.com
Tue Mar 31 00:38:26 UTC 2020
@jmacxx commented on this pull request.
> @@ -257,6 +260,7 @@ public Transaction completeBsqTradingFeeTx(Transaction preparedBsqTx,
checkNotNull(wallet, "Wallet must not be null");
wallet.completeTx(sendRequest);
Transaction resultTx = sendRequest.tx;
+ removeDust(resultTx);
At the moment there is only one way to get messages back to the GUI - via the errorMessage property on the Offer which is used by numerous exceptional events. I looked into reporting warnings back via adding a warningMessage property and will propose that as a new PR to address #3688. (Its a non-trivial change and I don't want to complicate this PR by adding it in here).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4094#discussion_r400575630
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200330/222f6a64/attachment.html>
More information about the bisq-github
mailing list