[bisq-network/bisq] Fix proof-of-burn signing for password protected wallets (#4221)

[Steven Barclay]

<!-- 
- make yourself familiar with the CONTRIBUTING.md if you have not already (https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md)
- make sure you follow our [coding style guidelines][https://github.com/bisq-network/style/issues)
- pick a descriptive title
- provide some meaningful PR description below
- create the PR
- in case you receive a "Change request" and/or a NACK, please react within 30 days. If not, we will close your PR and it can not be up for compensation.
- After addressing the change request, __please re-request a review!__ Otherwise we might miss your PR as we tend to only look at pull requests tagged with a "review required".
-->

Add a missing `bsqWalletService.isEncrypted()` check and optional AES key argument to the `signMessage(..)` call in `ProofOfBurnService`, analogous to the BitcoinJ call to sign with an EC key in `MyBlindVoteListService`.

This fixes #3836 (Proof of burn signing does not work if wallet password is set).

--

Unfortunately this PR touches the core DAO packages again, although it is fairly trivial.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4221

-- Commit Summary --

  * Fix proof-of-burn signing for password protected wallets

-- File Changes --

    M core/src/main/java/bisq/core/dao/governance/proofofburn/ProofOfBurnService.java (4)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4221.patch
https://github.com/bisq-network/bisq/pull/4221.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4221
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200501/70682ae7/attachment.html>