[bisq-network/bisq] Add rpc wallet protection endpoints (#4214)
notifications at github.com
Fri May 1 10:14:34 UTC 2020
@cbeams requested changes on this pull request.
NACK. @ghubstan, I have not comprehensively reviewed this yet, but it's clear so far that error handling will need some rework. You've built in `success` and `error_message` fields into the new `*Reply` definitions, but this is not idiomatic gRPC usage. gRPC provides a first-class `Status` object, which should be accessed via `StatusRuntimeExceptions` thrown from the server side and caught on the client. We're doing this already with invalid passwords, but we now need to do it more consistently from our services.
See https://grpc.io/docs/tutorials/basic/java/#calling-service-methods and https://github.com/grpc/grpc/blob/master/doc/statuscodes.md for details.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the bisq-github