[bisq-network/bisq] Add rpc wallet protection endpoints (#4214)

[Stan]

Notes about commit 2a9d1f6 (WIP)

@cbeams, 

I know you will look at all of the changes, but please review my use of the Tuple2 return type used in CoreApi?  Wrapping the return value and an ApiStatus code in a single return value -- for void return types too, unfortunately -- seemed like a better idea than throwing Exceptions to be caught by GrpcServer, to then be transformed into gRPC StatusRuntimeExceptions for the client.  I don't know what your preference is.  I prefer to make the changes after you ask for them.


And there is a lot of redundant error handling code in GrpcServer:

```
if (!result.second.equals(ApiStatus.OK)) {
	StatusRuntimeException ex = new StatusRuntimeException(result.second.getGrpcStatus()
	        .withDescription(result.second.getDescription()));
	responseObserver.onError(ex);
	throw ex;
}

```
There are only service classes in GrpcServer, no private methods yet.  I don't know if you want these duplicate code blocks factored out.







-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4214#issuecomment-622558564
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200501/6c7d874e/attachment-0001.html>