[bisq-network/bisq] Fix QR code display of offer funding amount (#4223)

James Cox notifications at github.com
Sat May 2 04:33:21 UTC 2020


When creating an offer the small QR code displayed for funding was off by an amount that represent the mining fees.  This was due to the QR code being displayed simultaneously with the wallet calulating the fee.

We fix the issue by listening to the data model `missingCoin` value of the offer object, and updating the QR code image appropriately.

Fixes #3666
Fixes #4194

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/4223

-- Commit Summary --

  * Fix QR code display of offer funding amount

-- File Changes --

    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferView.java (25)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/4223.patch
https://github.com/bisq-network/bisq/pull/4223.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4223
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200501/7f5df017/attachment.html>


More information about the bisq-github mailing list