[bisq-network/bisq] [WIP] Add memo field to withdrawal transaction (#4229)
Petr Hejna
notifications at github.com
Sun May 3 01:56:00 UTC 2020
- "Memo" field is modeled as property of the new object Transaction which is stored in persitant storage.
- Transaction object is modeled in a way that allows extension in the furure for more persisted attributes.
Will solve #1387
---------------
This is a Draft intended for early review because it is my first contribution during onboarding.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq/pull/4229
-- Commit Summary --
* Add memo field to withdrawal transaction
-- File Changes --
M core/src/main/java/bisq/core/proto/persistable/CorePersistenceProtoResolver.java (3)
A core/src/main/java/bisq/core/transaction/Transaction.java (29)
A core/src/main/java/bisq/core/transaction/TransactionsPayload.java (63)
M core/src/main/resources/i18n/displayStrings.properties (3)
M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionListItemFactory.java (20)
M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionsListItem.java (8)
M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionsView.fxml (1)
M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionsView.java (36)
M desktop/src/main/java/bisq/desktop/main/funds/withdrawal/WithdrawalView.java (34)
M proto/src/main/proto/pb.proto (14)
-- Patch Links --
https://github.com/bisq-network/bisq/pull/4229.patch
https://github.com/bisq-network/bisq/pull/4229.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4229
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200502/71450000/attachment.html>
More information about the bisq-github
mailing list