[bisq-network/bisq] Add rpc wallet protection endpoints (#4214)

Chris Beams notifications at github.com
Sun May 3 14:20:29 UTC 2020


@ghubstan, have a look at what I've done in 163061a to change the return type of `CoreWalletService#getAvailableBalance` from `Tuple2<Long, ApiStatus>` back to `long` and  how throwing `IllegalStateException` is now favored. The status of all `StatusRuntimeExceptions` is now set to `UNKNOWN`, as I don't see a requirement at this point for the client to differentiate between different gRPC status codes. We can introduce that later if need be. For now, this approach keeps `CoreWalletService` completely unaware of gRPC concepts (as if it were really located in `bisq.core` where we want it to be) and it its methods are left returning values and throwing exceptions in an idiomatic / plain old java fashion.

Could you refactor the remaining methods in `CoreWalletService` to follow suit? When finished, `ApiStatus` should be empty and therefore deleted, and there should no longer be any usage of `Tuple2`. Preferred is to refactor each method in its own commit. Thanks.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4214#issuecomment-623117234
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200503/42f1734a/attachment.html>


More information about the bisq-github mailing list