[bisq-network/bisq] User can set custom tx fee to override FeeService estimated fee (#4231)

[Chris Beams]

@cbeams requested changes on this pull request.

NACK.

We allow users to set a custom withdrawal transaction fee rate because it's their problem if they set it too low and end up queued in the mempool for an extended period.

We do not allow users to set a custom trading transaction fee rate because it creates a problem for their trading counterparty if they set it too low. The whole trade will get held up in such a case, and that's unfair to the counterparty who used the default fee or chose a more reasonable custom value.

Nit: for future PRs, please follow the commit guidelines at https://github.com/bisq-network/style/issues/9.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4231#pullrequestreview-404729904
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200503/3ee89247/attachment.html>