[bisq-network/bisq] Switch to more accurate fee estimation endpoint (#4235)

[Chris Beams]

@cbeams approved this pull request.

ACK. @cd2357, please see the review commit that I just pushed.

Note that there is an opportunity here for one or more follow-on PRs as well.

The first is to eliminate the `maxBlocks` field from `BitcoinFeeRateProvider`. You'll see my comments to this effect. Rolling this out means changing the startup scripts and communicating effectively about the change to @bisq-network/pricenode-operators. It would be great if you want to do this, @cd2357.

The second is implementing the configurability that @wiz mentioned in the comments on this PR. We could discuss the best way to do that. It would also be good to deliberate a little further on the implications of querying multiple backends first, though. We've never been in a situation where we could expect to get very divergent results for fee rate estimations, because we've always all been calling the same (earn.com) endpoint. We shouldn't be too hasty on making that switch, which is part of the reason I want to ship this fix as is, nice and minimal.

Really great work here, @cd2357. Thanks!

@wiz, when we merge this, will you drive the @bisq-network/pricenode-operators upgrading?



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/4235#pullrequestreview-405917893
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200505/6579a714/attachment.html>