[bisq-network/support] Add track-payments.html to report on payments to incident victims (#399)

Chris Beams notifications at github.com
Wed May 6 09:58:48 UTC 2020


@cbeams requested changes on this pull request.

NACK. @jmacxx, I just made a few review commits, but am unable to push them because your PR doesn't "allow maintainers to make edits". Please check that checkbox. In the meantime, take a look at the [`track-repayments` branch](https://github.com/bisq-network/support/tree/track-repayments) I just pushed, where you'll see my changes. In particular, see commit d863a0469abcf8c5a76e78ed65aa6ab0578fa023, where I update the repayment addresses to their current values from bisq-network/admin#76. After making this change, the call to the blockchair API returns 404. Doing a bit of debugging, I narrowed it down to the following:
Notice how this call, using victim 1's original repayment address returns OK:
```
$ http head https://api.blockchair.com/bitcoin/dashboards/addresses/1EU2aUQkHQukKbk3t5fmA4quHyMRBupM2U
HTTP/1.1 200 OK
```

Whereas the same request using victim 1's new repayment address value returns 404:
```
$ http head https://api.blockchair.com/bitcoin/dashboards/addresses/13sxMq8mTw7CTSqgGiMPfwo6ZDsVYrHLmR
HTTP/1.1 404 Not Found
```

The difference between these two addresses is that the first has had transactions move through it and the latter has not. It seems that blockchair is treating the latter as "not found" for that reason, which is not what we want here. Could you look into this and see if there's a fix? Thanks.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/pull/399#pullrequestreview-406465087
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20200506/4077d223/attachment.html>


More information about the bisq-github mailing list